components/url_formatter/elide_url.cc - Issue 1843063002: Don't show scheme in permission prompts if it is HTTPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_formatter/elide_url.cc

Issue 1843063002: Don't show scheme in permission prompts if it is HTTPS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/url_formatter/elide_url.cc

diff --git a/components/url_formatter/elide_url.cc b/components/url_formatter/elide_url.cc

index 45984304a0fd4dd99557e8db7e5f492044986bce..15798538fe68d420d98a3d8adc85464656dccbff 100644

--- a/components/url_formatter/elide_url.cc

+++ b/components/url_formatter/elide_url.cc

@@ -140,7 +140,7 @@ base::string16 FormatUrlForSecurityDisplayInternal(const GURL& url,

const std::string& host = origin.host();

base::string16 result;

- if (!omit_scheme || !url.SchemeIsHTTPOrHTTPS())

+ if (!omit_scheme || !url.SchemeIs(url::kHttpsScheme))

palmer 2016/03/30 20:23:34 Maybe url.SchemeIsCryptographic()?

result = base::UTF8ToUTF16(scheme) + scheme_separator;

result += base::UTF8ToUTF16(host);

« no previous file with comments | « components/url_formatter/elide_url.h ('k') | no next file » | no next file with comments »