Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 184303003: Fix handling of constant global variable assignments. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix handling of constant global variable assignments. BUG=347904 LOG=y R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19594

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : HConstant::DataEquals() is unusable due to the Unique mess. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M src/hydrogen.cc View 1 2 1 chunk +19 lines, -10 lines 0 comments Download
A + test/mjsunit/regress/regress-347904.js View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 9 months ago (2014-02-28 09:00:21 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 9 months ago (2014-02-28 09:12:02 UTC) #2
Benedikt Meurer
6 years, 9 months ago (2014-02-28 09:40:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r19594 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698