Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184303002: DevTools: support TRACE_VALUE_TYPE_COPY_STRING (Closed)

Created:
6 years, 9 months ago by caseq
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: support TRACE_VALUE_TYPE_COPY_STRING These strings need to be copied along with the event. We only used to support static strings so far. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M Source/core/inspector/TraceEventDispatcher.h View 2 chunks +13 lines, -3 lines 0 comments Download
M Source/core/inspector/TraceEventDispatcher.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
caseq
6 years, 9 months ago (2014-02-28 09:08:17 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-02-28 09:20:53 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-03-03 13:23:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/184303002/1
6 years, 9 months ago (2014-03-03 13:23:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 19:56:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24757
6 years, 9 months ago (2014-03-03 19:56:23 UTC) #6
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-03-04 05:46:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/184303002/1
6 years, 9 months ago (2014-03-04 05:46:47 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 05:47:07 UTC) #9
Message was sent while issue was closed. 
Change committed as 168363

Powered by Google App Engine
This is Rietveld 408576698