Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/revision_state.py

Issue 1843023002: Respecting repeat count for non perf bisects. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/bisect.expected/basic_return_code_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/revision_state.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/revision_state.py b/scripts/slave/recipe_modules/auto_bisect/revision_state.py
index 18b6a664ffa3036726316cd1631aa6855e244eb2..42ec033fd175ec88b7776ad4d0b89401cbc95ab6 100644
--- a/scripts/slave/recipe_modules/auto_bisect/revision_state.py
+++ b/scripts/slave/recipe_modules/auto_bisect/revision_state.py
@@ -92,10 +92,15 @@ class RevisionState(object):
self.mean_value = None
self.overall_return_code = None
self.std_dev = None
- self.repeat_count = MINIMUM_SAMPLE_SIZE
self._test_config = None
self.build_number = None
+ if self.bisector.test_type == 'perf':
+ self.repeat_count = MINIMUM_SAMPLE_SIZE
+ else:
+ self.repeat_count = self.bisector.bisect_config.get(
+ 'repeat_count', MINIMUM_SAMPLE_SIZE)
+
@property
def tested(self):
return self.status in (RevisionState.TESTED,)
« no previous file with comments | « no previous file | scripts/slave/recipes/bisect.expected/basic_return_code_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698