Add a method to determine when to show a one-time history notice in the CBD dialog

Add a method to determine when to show a one-time history notice in the CBD dialog

browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory
determines when we should show a permanent notice about other forms of
browsing history in the CBD dialog.

However, the one-time notice showed in a new dialog atop of CBD will
have different conditions. Add a separate method to browsing_data_ui
to determine that. Currently, the method defaults to the same value
as the aforementioned one; we are adding it to provide an interface for
the UI code. In the future, it will be updated with correct conditions.

BUG=595332
Committed: https://crrev.com/c628f837425d9bb578a29347d36be185662975c1
Cr-Commit-Position: refs/heads/master@{#384567}

[msramek, 2016-03-30 16:00:26]

msramek@chromium.org changed reviewers:
+ msarda@chromium.org

[msramek, 2016-03-30 16:00:26]

Hi Mihai,

as discussed offline, the discussion on conditions to show the history notice
has reopened, and it seems that we will have different conditions for the
permanent notice and for the one-time dialog. I added a new method for the
latter.

Please have a look!

Thanks,
Martin

[msramek, 2016-04-01 12:02:50]

Friendly ping. I'm already implementing the one-time dialog, so I need the
interface defined.

[msarda, 2016-04-01 12:05:21]

lgtm

[msramek, 2016-04-01 12:16:22]

Thank you!

[msramek, 2016-04-01 12:16:26]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-04-01 12:16:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843003003/1

[commit-bot: I haz the power, 2016-04-01 13:03:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-01 13:03:54]

Description was changed from

==========
Add a method to determine when to show a one-time history notice in the CBD
dialog

browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory
determines when we should show a permanent notice about other forms of
browsing history in the CBD dialog.

However, the one-time notice showed in a new dialog atop of CBD will
have different conditions. Add a separate method to browsing_data_ui
to determine that. Currently, the method defaults to the same value
as the aforementioned one; we are adding it to provide an interface for
the UI code. In the future, it will be updated with correct conditions.

BUG=595332
==========

to

==========
Add a method to determine when to show a one-time history notice in the CBD
dialog

browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory
determines when we should show a permanent notice about other forms of
browsing history in the CBD dialog.

However, the one-time notice showed in a new dialog atop of CBD will
have different conditions. Add a separate method to browsing_data_ui
to determine that. Currently, the method defaults to the same value
as the aforementioned one; we are adding it to provide an interface for
the UI code. In the future, it will be updated with correct conditions.

BUG=595332

Committed: https://crrev.com/c628f837425d9bb578a29347d36be185662975c1
Cr-Commit-Position: refs/heads/master@{#384567}
==========

[commit-bot: I haz the power, 2016-04-01 13:03:55]

Patchset 1 (id:??) landed as
https://crrev.com/c628f837425d9bb578a29347d36be185662975c1
Cr-Commit-Position: refs/heads/master@{#384567}