Sets correct ActivityLog enabled status to the first renderer process

chrome/browser/extensions/event_router.cc

Index: chrome/browser/extensions/event_router.cc
diff --git a/chrome/browser/extensions/event_router.cc b/chrome/browser/extensions/event_router.cc
index 4ef7a024f11be32e00d38de23d48892feb7fe4ed..00491503cea7d0d0af07725f82aefa383bdee743 100644
--- a/chrome/browser/extensions/event_router.cc
+++ b/chrome/browser/extensions/event_router.cc
@@ -109,7 +109,9 @@ void EventRouter::LogExtensionEventMessage(void* profile_id,
     Profile* profile = reinterpret_cast<Profile*>(profile_id);
     if (!g_browser_process->profile_manager()->IsValidProfile(profile))
       return;
-    ActivityLog::GetInstance(profile)->LogEventAction(
+    ActivityLog* activity_log = ActivityLog::GetInstance(profile);
+    if (!activity_log->IsLogEnabled()) return;
+    activity_log->LogEventAction(
         extension_id, event_name, event_args.get(), std::string());
   }
 }
@@ -122,10 +124,8 @@ void EventRouter::DispatchExtensionMessage(IPC::Sender* ipc_sender,
                                            ListValue* event_args,
                                            UserGestureState user_gesture,
                                            const EventFilteringInfo& info) {
-  if (ActivityLog::IsLogEnabledOnAnyProfile()) {

[felt, 2013/07/23 06:37:34]

Something I forgot about until now, and you should be aware of. This part is a
little tricky -- IsLogEnabledOnAnyProfile is, quite frankly, going to be wrong a
lot, so we 100% do want to get rid of it. However we can't switch to a
non-static method here because this method doesn't have a profile object. OTOH
it would be nice to not do this if the AL is disabled because dispatching the
IPC does have some cost.

The command line switch can be checked in a static method. Is there a way to
check prefs (perhaps all of the prefs) without using a profile object? If so we
could have a new, more-correct static method for here.

[pmarch, 2013/07/29 17:36:47]

Here, we need to check for command line switch and if the watchdog extension is
enabled. The command line switch can be checked statically but the watchdog
extension enable/disable status is per-profile. Thus we need to have a profile
object here.

I see two solutions:
1) implementing something similar to IsLogEnabledOnAnyProfile() 
2) moving message logging to the upper layer of IPC message handling where there
is a profile object available.

-    LogExtensionEventMessage(profile_id, extension_id, event_name,
-                             scoped_ptr<ListValue>(event_args->DeepCopy()));
-  }
+  LogExtensionEventMessage(profile_id, extension_id, event_name,
+                           scoped_ptr<ListValue>(event_args->DeepCopy()));
 
   ListValue args;
   args.Set(0, Value::CreateStringValue(event_name));