Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1842993002:
Spitzer: Report Opus in Ogg as supported by unified pipeline (Closed)
|
Created:
4 years, 8 months ago by ddorwin Modified:
4 years, 8 months ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpitzer: Report Opus in Ogg as supported by unified pipeline
BUG=598888
TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably to "probably".
Committed: https://crrev.com/65c03640c4f3e32b1ddeca63bc8503beda45d482
Cr-Commit-Position: refs/heads/master@{#383919}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
ddorwin@chromium.org changed reviewers: + dalecurtis@chromium.org
This is almost identical to the original code at https://codereview.chromium.org/1690063002/diff/80001/media/base/mime_util.cc....
lgtm
The CQ bit was checked by ddorwin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842993002/1
Description was changed from ========== Spitzer: Report Opus in Ogg as supported by unified pipeline BUG=598888 TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline. ========== to ========== Spitzer: Report Opus in Ogg as supported by unified pipeline BUG=598888 TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably. ==========
Description was changed from ========== Spitzer: Report Opus in Ogg as supported by unified pipeline BUG=598888 TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably. ========== to ========== Spitzer: Report Opus in Ogg as supported by unified pipeline BUG=598888 TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably to "probably". ==========
The CQ bit was unchecked by ddorwin@chromium.org
The CQ bit was checked by ddorwin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842993002/1
The CQ bit was unchecked by ddorwin@chromium.org
The CQ bit was checked by ddorwin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842993002/1
Message was sent while issue was closed.
Description was changed from ========== Spitzer: Report Opus in Ogg as supported by unified pipeline BUG=598888 TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably to "probably". ========== to ========== Spitzer: Report Opus in Ogg as supported by unified pipeline BUG=598888 TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably to "probably". ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Spitzer: Report Opus in Ogg as supported by unified pipeline BUG=598888 TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably to "probably". ========== to ========== Spitzer: Report Opus in Ogg as supported by unified pipeline BUG=598888 TEST=MediaCanPlayTypeTest.CodecSupportTest_ogg after switching the the default Android media pipleine to the unified pipeline and updating kOggOpusProbably to "probably". Committed: https://crrev.com/65c03640c4f3e32b1ddeca63bc8503beda45d482 Cr-Commit-Position: refs/heads/master@{#383919} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/65c03640c4f3e32b1ddeca63bc8503beda45d482 Cr-Commit-Position: refs/heads/master@{#383919} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
