Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1842933002: fix syntax error in mac_app.py (Closed)

Created:
4 years, 8 months ago by Elly Fong-Jones
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix syntax error in mac_app.py BUG= Committed: https://crrev.com/fe753fc5a44f7fdc481f4e5a6e66ab63d4476494 Cr-Commit-Position: refs/heads/master@{#383873}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/mac/mac_app.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
thakis: ptal? :)
4 years, 8 months ago (2016-03-29 21:22:36 UTC) #3
Nico
lgtm thanks! https://codereview.chromium.org/1842933002/diff/1/build/config/mac/mac_app.py File build/config/mac/mac_app.py (right): https://codereview.chromium.org/1842933002/diff/1/build/config/mac/mac_app.py#newcode58 build/config/mac/mac_app.py:58: application_path = os.path.join( args.dir, args.name + ".app", ...
4 years, 8 months ago (2016-03-29 21:41:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842933002/1
4 years, 8 months ago (2016-03-29 22:24:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 00:10:48 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 00:12:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe753fc5a44f7fdc481f4e5a6e66ab63d4476494
Cr-Commit-Position: refs/heads/master@{#383873}

Powered by Google App Engine
This is Rietveld 408576698