Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 184293008: Oilpan: fix build after changes that did not take oilpan into account. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-05 14:45:28 UTC) #1
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-05 14:45:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/184293008/1
6 years, 9 months ago (2014-03-05 14:47:04 UTC) #3
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-05 14:47:35 UTC) #4
haraken
LGTM This is a lucky case because the patch author used a RefPtr and thus ...
6 years, 9 months ago (2014-03-05 14:57:08 UTC) #5
Mads Ager (chromium)
On 2014/03/05 14:57:08, haraken wrote: > LGTM > > This is a lucky case because ...
6 years, 9 months ago (2014-03-05 14:58:23 UTC) #6
Mads Ager (chromium)
The CQ bit was unchecked by ager@chromium.org
6 years, 9 months ago (2014-03-05 15:35:40 UTC) #7
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-05 15:35:54 UTC) #8
Mads Ager (chromium)
The CQ bit was unchecked by ager@chromium.org
6 years, 9 months ago (2014-03-05 15:38:24 UTC) #9
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-05 15:38:29 UTC) #10
Mads Ager (chromium)
Committed patchset #1 manually as r168487 (presubmit successful).
6 years, 9 months ago (2014-03-05 15:43:26 UTC) #11
zerny-chromium
6 years, 9 months ago (2014-03-05 16:56:06 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698