Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/full-codegen.cc

Issue 18429005: Undefined is not a literal. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1587 matching lines...) Expand 10 before | Expand all | Expand 10 after
1598 1598
1599 1599
1600 bool FullCodeGenerator::TryLiteralCompare(CompareOperation* expr) { 1600 bool FullCodeGenerator::TryLiteralCompare(CompareOperation* expr) {
1601 Expression* sub_expr; 1601 Expression* sub_expr;
1602 Handle<String> check; 1602 Handle<String> check;
1603 if (expr->IsLiteralCompareTypeof(&sub_expr, &check)) { 1603 if (expr->IsLiteralCompareTypeof(&sub_expr, &check)) {
1604 EmitLiteralCompareTypeof(expr, sub_expr, check); 1604 EmitLiteralCompareTypeof(expr, sub_expr, check);
1605 return true; 1605 return true;
1606 } 1606 }
1607 1607
1608 if (expr->IsLiteralCompareUndefined(&sub_expr)) { 1608 if (expr->IsLiteralCompareUndefined(&sub_expr, isolate())) {
1609 EmitLiteralCompareNil(expr, sub_expr, kUndefinedValue); 1609 EmitLiteralCompareNil(expr, sub_expr, kUndefinedValue);
1610 return true; 1610 return true;
1611 } 1611 }
1612 1612
1613 if (expr->IsLiteralCompareNull(&sub_expr)) { 1613 if (expr->IsLiteralCompareNull(&sub_expr)) {
1614 EmitLiteralCompareNil(expr, sub_expr, kNullValue); 1614 EmitLiteralCompareNil(expr, sub_expr, kNullValue);
1615 return true; 1615 return true;
1616 } 1616 }
1617 1617
1618 return false; 1618 return false;
1619 } 1619 }
1620 1620
1621 1621
1622 #undef __ 1622 #undef __
1623 1623
1624 1624
1625 } } // namespace v8::internal 1625 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698