Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: third_party/buildbot_8_4p1/buildbot/status/web/status_json.py

Issue 18429003: Utilize buildCache in a smarter way to prevent pathological disk I/O storms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Add README.chromium diff. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/buildbot_8_4p1/buildbot/status/builder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/buildbot_8_4p1/buildbot/status/web/status_json.py
diff --git a/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py b/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py
index c3579390f43626750fc88daec81598f4da89fedc..e7cd932d10a0f874175a8b03bd0a9e29436e2278 100644
--- a/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py
+++ b/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py
@@ -641,8 +641,11 @@ class SlaveJsonResource(JsonResource):
if builderName not in buildercache:
buildercache.add(builderName)
builder_status = self.status.getBuilder(builderName)
- for i in range(1, builder_status.buildCacheSize - 1):
- build_status = builder_status.getBuild(-i)
+
+ buildnums = range(-1, -(builder_status.buildCacheSize - 1), -1)
+ builds = builder_status.getBuilds(buildnums)
+
+ for build_status in builds:
if not build_status or not build_status.isFinished():
# If not finished, it will appear in runningBuilds.
break
« no previous file with comments | « third_party/buildbot_8_4p1/buildbot/status/builder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698