Utilize buildCache in a smarter way to prevent pathological disk I/O storms.

third_party/buildbot_8_4p1/buildbot/status/web/status_json.py

Index: third_party/buildbot_8_4p1/buildbot/status/web/status_json.py
diff --git a/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py b/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py
index c3579390f43626750fc88daec81598f4da89fedc..deb2cc5f3efb82e364de5c0a0c6a44c0ae4f4e63 100644
--- a/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py
+++ b/third_party/buildbot_8_4p1/buildbot/status/web/status_json.py
@@ -641,8 +641,12 @@ class SlaveJsonResource(JsonResource):
             if builderName not in buildercache:
                 buildercache.add(builderName)
                 builder_status = self.status.getBuilder(builderName)
-                for i in range(1, builder_status.buildCacheSize - 1):
-                    build_status = builder_status.getBuild(-i)
+
+                buildnums = range(1, builder_status.buildCacheSize - 1)
+                buildnums = [-i for i in buildnums]

[iannucci, 2013/07/02 01:15:27]

range(-1, -(size - 1), -1)?

[Mike Stip (use stip instead), 2013/07/02 02:18:34]

Done.

+
+                builds = builder_status.getBuilds(buildnums)
+                for build_status in builds:
                     if not build_status or not build_status.isFinished():
                         # If not finished, it will appear in runningBuilds.
                         break