Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1842883002: cc : Check copy request count using effect tree (Closed)

Created:
4 years, 8 months ago by jaydasika
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Check copy request count using effect tree BUG=598748 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e6d2c0d7e018af2217598a8ec0b1b8f881a52af1 Cr-Commit-Position: refs/heads/master@{#383813}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M cc/trees/layer_tree_impl.cc View 1 1 chunk +16 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jaydasika
PTAL
4 years, 8 months ago (2016-03-29 19:13:00 UTC) #3
ajuma
lgtm https://codereview.chromium.org/1842883002/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1842883002/diff/1/cc/trees/layer_tree_impl.cc#newcode768 cc/trees/layer_tree_impl.cc:768: void SanityCheckCopyRequestCounts(LayerImpl* root_layer) { This is only using ...
4 years, 8 months ago (2016-03-29 19:30:43 UTC) #4
jaydasika
https://codereview.chromium.org/1842883002/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1842883002/diff/1/cc/trees/layer_tree_impl.cc#newcode768 cc/trees/layer_tree_impl.cc:768: void SanityCheckCopyRequestCounts(LayerImpl* root_layer) { On 2016/03/29 19:30:43, ajuma wrote: ...
4 years, 8 months ago (2016-03-29 19:35:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842883002/20001
4 years, 8 months ago (2016-03-29 19:35:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 20:49:12 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 20:50:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6d2c0d7e018af2217598a8ec0b1b8f881a52af1
Cr-Commit-Position: refs/heads/master@{#383813}

Powered by Google App Engine
This is Rietveld 408576698