Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1842863002: Reduce indentation in a section of build/common.gypi a bit. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce indentation in a section of build/common.gypi a bit. Use the common formatting for conditionals instead of something custom in a block of code I'm about to touch for something else. No behavior change. BUG=none Committed: https://crrev.com/110b1dcbe8d4e0db97cda79e3ce5d3a8eebed987 Cr-Commit-Position: refs/heads/master@{#383793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -76 lines) Patch
M build/common.gypi View 1 chunk +71 lines, -76 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
Despite how this looks, this just shifts a few blocks two spaces to the left ...
4 years, 8 months ago (2016-03-29 18:17:06 UTC) #2
scottmg
lgtm
4 years, 8 months ago (2016-03-29 18:56:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842863002/1
4 years, 8 months ago (2016-03-29 19:09:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 19:29:38 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 19:30:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/110b1dcbe8d4e0db97cda79e3ce5d3a8eebed987
Cr-Commit-Position: refs/heads/master@{#383793}

Powered by Google App Engine
This is Rietveld 408576698