Issue 1842853002: VM: Fix --no-use-field-guards.

Issue 1842853002: VM: Fix --no-use-field-guards. (Closed)

Created:
4 years, 8 months ago by Florian Schneider

Modified:
4 years, 8 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix --no-use-field-guards. Fields read from the snapshot must be initialized in the same way as when allocated with Field::New. BUG=https://github.com/dart-lang/sdk/issues/25957 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/15f23eedc9d9383a62aac36e31ff93a1ebb36b91

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
M	runtime/vm/jit_optimizer.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	tests/corelib/double_parse_test.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/corelib/num_sign_test.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/cha_deopt2_test.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/cha_deopt3_test.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

rmacnak

lgtm w/ heartbeat test Add tests/standalone/no_field_guards (compare tests/standalone/no_lazy_dispatchers et al).

4 years, 8 months ago (2016-03-29 18:15:07 UTC) #3

rmacnak

On 2016/03/29 18:15:07, rmacnak wrote: > lgtm w/ heartbeat test > > Add tests/standalone/no_field_guards (compare ...

4 years, 8 months ago (2016-03-29 21:36:20 UTC) #4

Florian Schneider

Yes, it fixes the issue mentioned. Added VMOptions to the tests mentioned in the issue.

4 years, 8 months ago (2016-03-30 00:31:26 UTC) #5

Florian Schneider

4 years, 8 months ago (2016-03-30 00:41:04 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
15f23eedc9d9383a62aac36e31ff93a1ebb36b91 (presubmit successful).