Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1842833003: [GN] Declare arm arguments when target_cpu == "arm". (Closed)

Created:
4 years, 8 months ago by slan
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, alokp
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Declare arm arguments when target_cpu == "arm". These variables should be declared when target_cpu is "arm", so that cross-compiles may use these arguments to determine how to build host tools. Related change in //v8: https://codereview.chromium.org/1839763003/ BUG=592660 Committed: https://crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 Cr-Commit-Position: refs/heads/master@{#383888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/arm.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
slan
Hey Dirk, this is follow-up from your comment here: https://codereview.chromium.org/1839763003/diff/1/BUILD.gn#newcode174 PTAL.
4 years, 8 months ago (2016-03-29 23:42:52 UTC) #2
slan
4 years, 8 months ago (2016-03-29 23:43:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842833003/1
4 years, 8 months ago (2016-03-30 00:32:06 UTC) #7
Dirk Pranke
lgtm
4 years, 8 months ago (2016-03-30 01:03:46 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 01:08:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842833003/1
4 years, 8 months ago (2016-03-30 01:13:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 01:20:52 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 01:23:27 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0
Cr-Commit-Position: refs/heads/master@{#383888}

Powered by Google App Engine
This is Rietveld 408576698