src/effects/SkPictureImageFilter.cpp - Issue 1842793002: Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkPictureImageFilter.cpp

Issue 1842793002: Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: clean up Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkPictureImageFilter.cpp

diff --git a/src/effects/SkPictureImageFilter.cpp b/src/effects/SkPictureImageFilter.cpp

index 8f8853ec36e7f8c3fc009306d5dfd2f9c08cbf5a..743bb8ba2535e7a38f62edabf856571acd53af60 100644

--- a/src/effects/SkPictureImageFilter.cpp

+++ b/src/effects/SkPictureImageFilter.cpp

@@ -14,7 +14,7 @@

#include "SkValidationUtils.h"

SkPictureImageFilter::SkPictureImageFilter(sk_sp<SkPicture> picture)

- : INHERITED(0, 0, nullptr)

+ : INHERITED(nullptr, 0, nullptr)

, fPicture(std::move(picture))

, fCropRect(fPicture ? fPicture->cullRect() : SkRect::MakeEmpty())

, fPictureResolution(kDeviceSpace_PictureResolution)

@@ -24,7 +24,7 @@ SkPictureImageFilter::SkPictureImageFilter(sk_sp<SkPicture> picture)

SkPictureImageFilter::SkPictureImageFilter(sk_sp<SkPicture> picture, const SkRect& cropRect,

PictureResolution pictureResolution,

SkFilterQuality filterQuality)

- : INHERITED(0, 0, nullptr)

+ : INHERITED(nullptr, 0, nullptr)

, fPicture(std::move(picture))

, fCropRect(cropRect)

, fPictureResolution(pictureResolution)

« src/core/SkImageFilter.cpp ('K') | « src/effects/SkPaintImageFilter.cpp ('k') | tests/ImageFilterTest.cpp » ('j') | no next file with comments »