src/core/SkCanvas.cpp - Issue 1842793002: Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 1842793002: Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Ooops Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index f1777441d65b305a11dd442ab4ef35834b991a89..2f6477c41dec49be7cdc59cb3014364efff34a5a 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -1161,9 +1161,8 @@ static void draw_filter_into_device(SkBaseDevice* src, const SkImageFilter* filt

SkCanvas c(dst);

- SkAutoTUnref<SkImageFilter> localF(filter->newWithLocalMatrix(ctm));

SkPaint p;

- p.setImageFilter(localF);

+ p.setImageFilter(filter->makeWithLocalMatrix(ctm));

const SkScalar x = SkIntToScalar(src->getOrigin().x());

const SkScalar y = SkIntToScalar(src->getOrigin().y());

c.drawBitmap(srcBM, x, y, &p);

« no previous file with comments | « samplecode/SampleFilterFuzz.cpp ('k') | src/core/SkImageFilter.cpp » ('j') | no next file with comments »