Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1842743002: [printing] Add COW identifier to elements kind (Closed)

Created:
4 years, 8 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[printing] Add COW identifier to elements kind BUG= Committed: https://crrev.com/35fa419a2fe211c9ad55259db625c622f5f51ecd Cr-Commit-Position: refs/heads/master@{#35157}

Patch Set 1 #

Total comments: 2

Patch Set 2 : print elements and only print COW for smi/object elements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/objects-printer.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Camillo Bruni
PTAL
4 years, 8 months ago (2016-03-29 13:33:30 UTC) #3
Toon Verwaest
https://codereview.chromium.org/1842743002/diff/1/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/1842743002/diff/1/src/objects-printer.cc#newcode399 src/objects-printer.cc:399: PrototypeIterator iter(obj->GetIsolate(), obj); Move iter down to where it's ...
4 years, 8 months ago (2016-03-29 13:42:50 UTC) #4
Camillo Bruni
PTAL again
4 years, 8 months ago (2016-03-30 09:21:14 UTC) #5
Toon Verwaest
lgtm
4 years, 8 months ago (2016-03-31 08:27:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842743002/20001
4 years, 8 months ago (2016-03-31 09:31:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 10:11:50 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 10:13:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35fa419a2fe211c9ad55259db625c622f5f51ecd
Cr-Commit-Position: refs/heads/master@{#35157}

Powered by Google App Engine
This is Rietveld 408576698