Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 184273011: Merge 253787 "[GCM] Make sure GCM checkout logic is invoked when..." (Closed)

Created:
6 years, 9 months ago by jianli
Modified:
6 years, 9 months ago
Reviewers:
jianli
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, jar (doing other things), haitaol+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, Ilya Sherman, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Merge 253787 "[GCM] Make sure GCM checkout logic is invoked when..." > [GCM] Make sure GCM checkout logic is invoked when the profile is signed out > > We now always create GCMProfileService that listens to profile > notifications such that GCM checkout logic could be invoked when the > profile is signed out. > > We now move the GCM check-in logic from GCMClient::Initialize to GCMClient::CheckIn. > > BUG=344031 > TEST=new tests added and existing tests updated > > Review URL: https://codereview.chromium.org/165993005 TBR=jianli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255193

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -228 lines) Patch
M chrome/browser/extensions/api/gcm/gcm_api.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 3 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/services/gcm/fake_gcm_profile_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_profile_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/services/gcm/gcm_client_mock.h View 5 chunks +22 lines, -9 lines 0 comments Download
M chrome/browser/services/gcm/gcm_client_mock.cc View 9 chunks +40 lines, -26 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.h View 5 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 16 chunks +98 lines, -71 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_factory.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 17 chunks +143 lines, -41 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M google_apis/gcm/gcm_client.h View 3 chunks +6 lines, -4 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 3 chunks +6 lines, -1 line 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 1 6 chunks +45 lines, -27 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jianli
6 years, 9 months ago (2014-03-06 00:57:42 UTC) #1
jianli
6 years, 9 months ago (2014-03-06 01:11:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r255193.

Powered by Google App Engine
This is Rietveld 408576698