chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 184273010: Fix artifacts on the Apps button with CoreAnimation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 184273010: Fix artifacts on the Apps button with CoreAnimation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 500s Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index 26e594d0858d8f4a7da6057f15070bb2ff6aa7ff..d94bbe67d6a7a96ee9db7de1973efc14ddc0d1f6 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -482,6 +482,8 @@ void RecordAppLaunch(Profile* profile, GURL url) {

// Update bookmark button backgrounds.

if ([self isAnimationRunning]) {

+ [appsPageShortcutButton_ setNeedsDisplay:YES];

+ [otherBookmarksButton_ setNeedsDisplay:YES];

Avi (use Gerrit) 2014/03/06 03:42:48 Explain with a brief comment?

ccameron 2014/03/06 07:06:55 Done.

for (NSButton* button in buttons_.get())

[button setNeedsDisplay:YES];

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »