Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 184273006: Revert 254986 "Switch thread_local to use chromium's TLS impleme..." (Closed)

Created:
6 years, 9 months ago by oshima
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 254986 "Switch thread_local to use chromium's TLS impleme..." > Switch thread_local to use chromium's TLS implementation > > This patch switch thread_local to use ThreadLocalStorage::Slot, so it get the > TLS slot from the chromium's TLS instead of OS's. > > There is debate whether the Windows' TLS's destructor implementation is reliable > or not, if we are able to remove all the use of TLS destructor, only ThreadLocalStorage::Slot > needs to change, as thread_local doesn't use TLS destructor at all. > > BUG=264406 > > Review URL: https://codereview.chromium.org/139633003 TBR=michaelbai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
trunk/src/base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
trunk/src/base/threading/thread_local.h View 1 chunk +34 lines, -6 lines 0 comments Download
trunk/src/base/threading/thread_local_posix.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
trunk/src/base/threading/thread_local_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
trunk/src/base/threading/thread_local_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
6 years, 9 months ago (2014-03-05 18:47:41 UTC) #1
oshima
Committed patchset #1 manually as r255102.
6 years, 9 months ago (2014-03-05 18:47:48 UTC) #2
Ken Russell (switch to Gerrit)
When reverting CLs, could you please add a brief description of why it was reverted, ...
6 years, 9 months ago (2014-03-05 19:10:34 UTC) #3
oshima
On 2014/03/05 19:10:34, Ken Russell wrote: > When reverting CLs, could you please add a ...
6 years, 9 months ago (2014-03-05 19:17:46 UTC) #4
Ken Russell (switch to Gerrit)
6 years, 9 months ago (2014-03-05 19:23:21 UTC) #5
Message was sent while issue was closed.
Thanks. These TLS changes caused severe problems on the GPU bots at one point,
so I appreciate knowing the symptom of the new failure.

Powered by Google App Engine
This is Rietveld 408576698