Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 184273003: Allow overriding the serialization rules in MarkupAccumulator (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, Stephen Chennney
Visibility:
Public.

Description

Allow overriding the serialization rules in MarkupAccumulator Add a flag for overriding the default policy of basing the serialization on the type of the owner document. Use in XMLSerializer to force serialization of character entities based on XML rules. BUG=340794 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168819

Patch Set 1 #

Patch Set 2 : Adjust some more tests. #

Patch Set 3 : Adjust one more test. #

Patch Set 4 : Rebased onto split out CLs. #

Messages

Total messages: 9 (0 generated)
fs
This ended up with more "Also..." than I had anticipated... They're however fairly easily recognizable. ...
6 years, 9 months ago (2014-03-05 17:09:51 UTC) #1
adamk
On 2014/03/05 17:09:51, fs wrote: > This ended up with more "Also..." than I had ...
6 years, 9 months ago (2014-03-05 19:48:07 UTC) #2
fs
On 2014/03/05 19:48:07, adamk wrote: > On 2014/03/05 17:09:51, fs wrote: > > This ended ...
6 years, 9 months ago (2014-03-06 13:34:15 UTC) #3
adamk
Ping back when this is rebased against those other changes...
6 years, 9 months ago (2014-03-06 19:32:49 UTC) #4
fs
Rebased on top of the two split out CLs. PTAL.
6 years, 9 months ago (2014-03-07 12:41:32 UTC) #5
adamk
lgtm Thanks for splitting them up.
6 years, 9 months ago (2014-03-07 18:32:33 UTC) #6
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-03-10 08:43:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/184273003/60001
6 years, 9 months ago (2014-03-10 08:43:13 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 08:55:36 UTC) #9
Message was sent while issue was closed.
Change committed as 168819

Powered by Google App Engine
This is Rietveld 408576698