Fixes handling of short reads/writes for Mac SSL

Fixes handling of short reads/writes for Mac SSL

The SecureTransport API is a bit finicky about the return code
and length from SSL{Read,Write}Callback. I think I've got it
right now, but we'll have to keep an eye on it.

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104

R=iposva@google.com

Committed: https://github.com/dart-lang/sdk/commit/5cee7ff634e715f6b2b0c8bfa3980206545d6916

[zra, 2016-03-29 16:47:07]

Description was changed from

==========
Corret handling of short reads/writes for Mac SSL
==========

to

==========
Correct handling of short reads/writes for Mac SSL

related #26104
==========

[zra, 2016-03-29 16:48:04]

Description was changed from

==========
Correct handling of short reads/writes for Mac SSL

related #26104
==========

to

==========
Correct handling of short reads/writes for Mac SSL

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104
==========

[zra, 2016-03-29 16:50:53]

Description was changed from

==========
Correct handling of short reads/writes for Mac SSL

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104
==========

to

==========
Fixes handling of short reads/writes for Mac SSL

The SecureTransport API is a bit finicky about the return code and length from
SSL{Read,Write}Callback. I think I've got it right now,
but we'll have to keep an eye on it.

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104
==========

[zra, 2016-03-29 16:53:33]

Description was changed from

==========
Fixes handling of short reads/writes for Mac SSL

The SecureTransport API is a bit finicky about the return code and length from
SSL{Read,Write}Callback. I think I've got it right now,
but we'll have to keep an eye on it.

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104
==========

to

==========
Fixes handling of short reads/writes for Mac SSL

The SecureTransport API is a bit finicky about the return code
and length from SSL{Read,Write}Callback. I think I've got it
right now, but we'll have to keep an eye on it.

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104
==========

[zra, 2016-03-29 16:54:18]

zra@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2016-03-29 17:14:17]

LGTM -ip

https://codereview.chromium.org/1842703003/diff/1/runtime/bin/secure_socket_m...
File runtime/bin/secure_socket_macos.cc (right):

https://codereview.chromium.org/1842703003/diff/1/runtime/bin/secure_socket_m...
runtime/bin/secure_socket_macos.cc:1902: return noErr;
return short_read ? errSSLWouldBlock : noErr;

https://codereview.chromium.org/1842703003/diff/1/runtime/bin/secure_socket_m...
runtime/bin/secure_socket_macos.cc:1995: return noErr;
ditto.

https://codereview.chromium.org/1842703003/diff/1/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/1842703003/diff/1/sdk/lib/io/secure_socket.da...
sdk/lib/io/secure_socket.dart:876: if
(_filterStatus.writeEncryptedNoLongerEmpty) _writeSocket();
{}s

[zra, 2016-03-29 17:29:20]

https://codereview.chromium.org/1842703003/diff/1/runtime/bin/secure_socket_m...
File runtime/bin/secure_socket_macos.cc (right):

https://codereview.chromium.org/1842703003/diff/1/runtime/bin/secure_socket_m...
runtime/bin/secure_socket_macos.cc:1902: return noErr;
On 2016/03/29 17:14:16, Ivan Posva wrote:
> return short_read ? errSSLWouldBlock : noErr;

Done.

https://codereview.chromium.org/1842703003/diff/1/runtime/bin/secure_socket_m...
runtime/bin/secure_socket_macos.cc:1995: return noErr;
On 2016/03/29 17:14:16, Ivan Posva wrote:
> ditto.

Done.

https://codereview.chromium.org/1842703003/diff/1/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/1842703003/diff/1/sdk/lib/io/secure_socket.da...
sdk/lib/io/secure_socket.dart:876: if
(_filterStatus.writeEncryptedNoLongerEmpty) _writeSocket();
On 2016/03/29 17:14:17, Ivan Posva wrote:
> {}s

Done.

[zra, 2016-03-29 17:30:13]

Description was changed from

==========
Fixes handling of short reads/writes for Mac SSL

The SecureTransport API is a bit finicky about the return code
and length from SSL{Read,Write}Callback. I think I've got it
right now, but we'll have to keep an eye on it.

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104
==========

to

==========
Fixes handling of short reads/writes for Mac SSL

The SecureTransport API is a bit finicky about the return code
and length from SSL{Read,Write}Callback. I think I've got it
right now, but we'll have to keep an eye on it.

Also a small tweak to avoid an extra trip through the event loop
before putting a write event on the secure socket stream.

related #26104

R=iposva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5cee7ff634e715f6b2b0c8bfa3980206545d6916
==========

[zra, 2016-03-29 17:30:14]

Committed patchset #2 (id:20001) manually as
5cee7ff634e715f6b2b0c8bfa3980206545d6916 (presubmit successful).