Issue 18427003: Switch to RETURN_IF_EMPTY_HANDLE for empty handle checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18427003: Switch to RETURN_IF_EMPTY_HANDLE for empty handle checks. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger

Modified:
7 years, 5 months ago

Reviewers:
Michael Achenbach, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Switch to RETURN_IF_EMPTY_HANDLE for empty handle checks. This makes sure that every place where we assume an empty handle is indicating a pending exception gets asserted accordingly. R=machenbach@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15509

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
	M	src/runtime.cc	View		12 chunks	+13 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

LGTM with nit: In issue description: "a pending exception" or "pending exceptions".

7 years, 5 months ago (2013-07-05 09:36:23 UTC) #2

Michael Starzinger

7 years, 5 months ago (2013-07-05 09:49:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15509 (presubmit successful).