[Autofill] Fill fields where the value equals the placeholder attribute.

If the value of the field is the same as the placeholder attribute value, it is safe to overwrite this field with autofill values.

BUG=599131
TEST=FormAutofillBrowserTest, AutofillManagerTest

Committed: https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88
Cr-Commit-Position: refs/heads/master@{#384053}

[sebsg, 2016-03-29 13:15:41]

Description was changed from

==========
Ds

BUG=
==========

to

==========
If the value of the field is the same as the placeholder attribute value, it is
safe to overwrite this field with autofill values.

BUG=
TEST=FormAutofillBrowserTest
==========

[sebsg, 2016-03-30 15:05:37]

Patchset #2 (id:20001) has been deleted

[sebsg, 2016-03-30 15:05:43]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-03-30 15:11:12]

Description was changed from

==========
If the value of the field is the same as the placeholder attribute value, it is
safe to overwrite this field with autofill values.

BUG=
TEST=FormAutofillBrowserTest
==========

to

==========
If the value of the field is the same as the placeholder attribute value, it is
safe to overwrite this field with autofill values.

BUG=599131
TEST=FormAutofillBrowserTest, AutofillManagerTest
==========

[sebsg, 2016-03-30 16:13:20]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2016-03-30 16:13:21]

Hi Math could you please take a look? Thanks!

[sebsg, 2016-03-30 16:18:55]

Patchset #1 (id:40001) has been deleted

[Mathieu, 2016-03-30 17:36:24]

lgtm

https://codereview.chromium.org/1842693003/diff/60001/components/autofill/cor...
File components/autofill/core/common/form_field_data.cc (right):

https://codereview.chromium.org/1842693003/diff/60001/components/autofill/cor...
components/autofill/core/common/form_field_data.cc:141: return true;
nit: bring to previous line>?

https://codereview.chromium.org/1842693003/diff/60001/components/autofill/cor...
components/autofill/core/common/form_field_data.cc:142: if (placeholder >
field.placeholder)
same

[sebsg, 2016-03-30 17:44:14]

Thanks

https://codereview.chromium.org/1842693003/diff/60001/components/autofill/cor...
File components/autofill/core/common/form_field_data.cc (right):

https://codereview.chromium.org/1842693003/diff/60001/components/autofill/cor...
components/autofill/core/common/form_field_data.cc:141: return true;
On 2016/03/30 17:36:23, Mathieu Perreault wrote:
> nit: bring to previous line>?

Weirdly git cl format put it on two lines only for this one...

https://codereview.chromium.org/1842693003/diff/60001/components/autofill/cor...
components/autofill/core/common/form_field_data.cc:142: if (placeholder >
field.placeholder)
On 2016/03/30 17:36:23, Mathieu Perreault wrote:
> same

Done.

[sebsg, 2016-03-30 17:47:57]

sebsg@chromium.org changed reviewers:
+ kenrb@chromium.org

[sebsg, 2016-03-30 17:47:57]

kenrb@chromium.org: Could you please review
components/autofill/content/common/autofill_messages.h

Thanks!

[kenrb, 2016-03-30 18:04:01]

lgtm

[sebsg, 2016-03-30 18:05:42]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-03-30 18:05:43]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/1842693003/#ps80001
(title: "Nits")

[commit-bot: I haz the power, 2016-03-30 18:06:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842693003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842693003/80001

[commit-bot: I haz the power, 2016-03-30 19:28:36]

Description was changed from

==========
If the value of the field is the same as the placeholder attribute value, it is
safe to overwrite this field with autofill values.

BUG=599131
TEST=FormAutofillBrowserTest, AutofillManagerTest
==========

to

==========
If the value of the field is the same as the placeholder attribute value, it is
safe to overwrite this field with autofill values.

BUG=599131
TEST=FormAutofillBrowserTest, AutofillManagerTest
==========

[commit-bot: I haz the power, 2016-03-30 19:28:38]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-03-30 20:05:17]

Description was changed from

==========
If the value of the field is the same as the placeholder attribute value, it is
safe to overwrite this field with autofill values.

BUG=599131
TEST=FormAutofillBrowserTest, AutofillManagerTest
==========

to

==========
If the value of the field is the same as the placeholder attribute value, it is
safe to overwrite this field with autofill values.

BUG=599131
TEST=FormAutofillBrowserTest, AutofillManagerTest

Committed: https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88
Cr-Commit-Position: refs/heads/master@{#384053}
==========

[commit-bot: I haz the power, 2016-03-30 20:05:18]

Patchset 2 (id:??) landed as
https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88
Cr-Commit-Position: refs/heads/master@{#384053}