Chromium Code Reviews

Issue 1842693002: Avoid applying alpha twice in RenderText. (Closed)

Created:
4 years, 8 months ago by Mikus
Modified:
4 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid applying alpha twice in RenderText. BUG=575186 Committed: https://crrev.com/f700cdb9e7a4cd1a959d2e9fadb3b3cb7fa6282d Cr-Commit-Position: refs/heads/master@{#384055}

Patch Set 1 #

Patch Set 2 : Cherry pick the correct patch... #

Unified diffs Side-by-side diffs Stats (+5 lines, -1 line)
M ui/gfx/render_text.cc View 2 chunks +5 lines, -1 line 0 comments

Messages

Total messages: 12 (5 generated)
Mikus
On 2016/03/29 09:54:34, Mikus wrote: > mailto:mboc@opera.com changed reviewers: > + mailto:msw@chromium.org I can't cope ...
4 years, 8 months ago (2016-03-29 09:54:56 UTC) #3
msw
This isn't the same change as the latest patch set on https://codereview.chromium.org/1567363002
4 years, 8 months ago (2016-03-29 18:56:24 UTC) #4
Mikus
On 2016/03/29 18:56:24, msw wrote: > This isn't the same change as the latest patch ...
4 years, 8 months ago (2016-03-30 07:42:18 UTC) #5
msw
lgtm
4 years, 8 months ago (2016-03-30 17:37:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842693002/20001
4 years, 8 months ago (2016-03-30 18:02:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 19:34:41 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:05:25 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f700cdb9e7a4cd1a959d2e9fadb3b3cb7fa6282d
Cr-Commit-Position: refs/heads/master@{#384055}

Powered by Google App Engine