Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1842673003: Revert of Mac: Decode hardware to 420 instead of 422 (Closed)

Created:
4 years, 8 months ago by ccameron
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mac: Decode hardware to 420 instead of 422 (patchset #3 id:40001 of https://codereview.chromium.org/1822173002/ ) Reason for revert: This likely spiked the crash rates. BUG=598388 Original issue's description: > Mac: Decode hardware to 420 instead of 422 > > If the decoded frame is going to be used as a CALayer overlay, then > it will never be converted to RGBA. If it is used by OpenGL, then the > same infrastructure for software frames will be employed to make an > expensive RGBA copy of the frame. > > BUG=594452 > > Committed: https://crrev.com/24da601d444c8822c5ff0a10751b9384f25dd1b4 > Cr-Commit-Position: refs/heads/master@{#382797} TBR=sandersd@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=594452 Committed: https://crrev.com/bd8763305febe8b7c2467734848bfd42bead244a Cr-Commit-Position: refs/heads/master@{#383823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -51 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.h View 1 chunk +2 lines, -5 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 3 chunks +6 lines, -4 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator_mac.h View 2 chunks +6 lines, -4 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator_mac.cc View 6 chunks +48 lines, -21 lines 0 comments Download
M media/video/video_decode_accelerator.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ccameron
Created Revert of Mac: Decode hardware to 420 instead of 422
4 years, 8 months ago (2016-03-29 19:45:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842673003/1
4 years, 8 months ago (2016-03-29 19:46:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842673003/1
4 years, 8 months ago (2016-03-29 20:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842673003/1
4 years, 8 months ago (2016-03-29 20:32:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842673003/1
4 years, 8 months ago (2016-03-29 21:01:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 21:08:02 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:09:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd8763305febe8b7c2467734848bfd42bead244a
Cr-Commit-Position: refs/heads/master@{#383823}

Powered by Google App Engine
This is Rietveld 408576698