Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1842663002:
Deflake two IME tests (Closed)
|
Created:
4 years, 8 months ago by Changwan Ryu Modified:
4 years, 8 months ago Reviewers:
aelias_OOO_until_Jul13 CC:
chromium-reviews, darin-cc_chromium.org, jam, gone Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDeflake two IME tests
In testSelectionClearedOnKeyEvent and
testKeyboardNotDismissedAfterCopySelection,
we first click on the text, and then long-press the text. This call
sequence seems to cause flakiness depending on the timing.
Since we can trigger context popup menu even when the input form is not
focused, we don't need the first clicks for these tests.
Also change a bit more to make the tests extra robust.
TBR=aelias@chromium.org
BUG=598482
Committed: https://crrev.com/2f60b340b4082340c921c7b3a2fefb56e930aa5b
Cr-Commit-Position: refs/heads/master@{#383687}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by changwan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842663002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2016/03/29 07:40:10, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. lgtm
The CQ bit was checked by changwan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842663002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
changwan@chromium.org changed reviewers: + aelias@chromium.org
Description was changed from ========== Deflake two IME tests In testSelectionClearedOnKeyEvent and testKeyboardNotDismissedAfterCopySelection, we first click on the text, and then long-press the text. This call sequence seems to cause flakiness depending on the timing. Since we can trigger context popup menu even when the input form is not focused, we don't need the first clicks for these tests. Also change a bit more to make the tests extra robust. BUG=598482 ========== to ========== Deflake two IME tests In testSelectionClearedOnKeyEvent and testKeyboardNotDismissedAfterCopySelection, we first click on the text, and then long-press the text. This call sequence seems to cause flakiness depending on the timing. Since we can trigger context popup menu even when the input form is not focused, we don't need the first clicks for these tests. Also change a bit more to make the tests extra robust. TBR=aelias@chromium.org BUG=598482 ==========
The CQ bit was checked by changwan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842663002/1
Message was sent while issue was closed.
Description was changed from ========== Deflake two IME tests In testSelectionClearedOnKeyEvent and testKeyboardNotDismissedAfterCopySelection, we first click on the text, and then long-press the text. This call sequence seems to cause flakiness depending on the timing. Since we can trigger context popup menu even when the input form is not focused, we don't need the first clicks for these tests. Also change a bit more to make the tests extra robust. TBR=aelias@chromium.org BUG=598482 ========== to ========== Deflake two IME tests In testSelectionClearedOnKeyEvent and testKeyboardNotDismissedAfterCopySelection, we first click on the text, and then long-press the text. This call sequence seems to cause flakiness depending on the timing. Since we can trigger context popup menu even when the input form is not focused, we don't need the first clicks for these tests. Also change a bit more to make the tests extra robust. TBR=aelias@chromium.org BUG=598482 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Deflake two IME tests In testSelectionClearedOnKeyEvent and testKeyboardNotDismissedAfterCopySelection, we first click on the text, and then long-press the text. This call sequence seems to cause flakiness depending on the timing. Since we can trigger context popup menu even when the input form is not focused, we don't need the first clicks for these tests. Also change a bit more to make the tests extra robust. TBR=aelias@chromium.org BUG=598482 ========== to ========== Deflake two IME tests In testSelectionClearedOnKeyEvent and testKeyboardNotDismissedAfterCopySelection, we first click on the text, and then long-press the text. This call sequence seems to cause flakiness depending on the timing. Since we can trigger context popup menu even when the input form is not focused, we don't need the first clicks for these tests. Also change a bit more to make the tests extra robust. TBR=aelias@chromium.org BUG=598482 Committed: https://crrev.com/2f60b340b4082340c921c7b3a2fefb56e930aa5b Cr-Commit-Position: refs/heads/master@{#383687} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2f60b340b4082340c921c7b3a2fefb56e930aa5b Cr-Commit-Position: refs/heads/master@{#383687} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
