Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Unified Diff: third_party/protobuf/protobuf_nacl.gyp

Issue 1842653006: Update //third_party/protobuf to version 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update sync unittest and README.chromium Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/protobuf_nacl.gyp
diff --git a/third_party/protobuf/protobuf_nacl.gyp b/third_party/protobuf/protobuf_nacl.gyp
index ae37f2f01502d0d699357c10bf1dd1c235d6a69f..6fb3ac216ce291f65900edecd91ed6b72536425d 100644
--- a/third_party/protobuf/protobuf_nacl.gyp
+++ b/third_party/protobuf/protobuf_nacl.gyp
@@ -15,7 +15,6 @@
'build_glibc': 0,
'build_newlib': 0,
'build_pnacl_newlib': 1,
- 'config_h_dir': '.',
},
'pnacl_compile_flags': [
Peter Kasting 2016/04/06 22:35:39 You should be able to remove this block, I think.
xyzzyz 2016/04/07 18:55:02 Done.
# This disables #warning in hash_map/hash_set headers which are
@@ -28,6 +27,12 @@
'includes': [
'protobuf_lite.gypi',
],
+ 'defines': [
+ # protobuf requires these to be set manually, as it no longer
+ # uses config.h
+ 'HAVE_ZLIB',
Peter Kasting 2016/04/06 22:35:39 Do you really need this?
xyzzyz 2016/04/07 18:55:02 Seems like I actually don't. Thanks!
+ 'HAVE_PTHREAD',
Peter Kasting 2016/04/06 22:35:39 In my roll attempt I set this in protobuf_lite.gyp
xyzzyz 2016/04/07 18:55:02 I set it in protobuf.gyp, and it seems you're righ
Peter Kasting 2016/04/07 23:25:38 If it affects files listed in protobuf_lit.gypi, t
xyzzyz 2016/04/11 19:34:40 Done.
+ ],
}, # end of target 'protobuf_lite_nacl'
]
}

Powered by Google App Engine
This is Rietveld 408576698