Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: build/common.gypi

Issue 1842653006: Update //third_party/protobuf to version 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/internal_api/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 2fec6dd7c18cb1e62c0b5fea3683a8adf6549d4e..ef235d7716b49f41dba46a9a4dd08858dfac2e17 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2852,13 +2852,6 @@
['OS=="win"', {
'defines': ['NO_TCMALLOC'],
}],
- ['asan==1', {
- 'defines': [
- 'ADDRESS_SANITIZER',
- 'MEMORY_TOOL_REPLACES_ALLOCATOR',
- 'MEMORY_SANITIZER_INITIAL_SIZE',
- ],
- }],
['syzyasan==1', {
# SyzyAsan needs /PROFILE turned on to produce appropriate pdbs.
'msvs_settings': {
@@ -3079,6 +3072,13 @@
['<(chromeos)==1 and >(nacl_untrusted_build)==0', {
'defines': ['OS_CHROMEOS=1'],
}],
+ ['<(asan)==1 and >(nacl_untrusted_build)==0', {
+ 'defines': [
+ 'ADDRESS_SANITIZER',
+ 'MEMORY_TOOL_REPLACES_ALLOCATOR',
+ 'MEMORY_SANITIZER_INITIAL_SIZE',
+ ],
+ }],
['enable_wexit_time_destructors==1 and OS!="win"', {
# TODO: Enable on Windows too, http://crbug.com/404525
'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
« no previous file with comments | « no previous file | sync/internal_api/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698