Update //third_party/protobuf to version 3.

third_party/protobuf/cleanup_release.sh

+#!/bin/bash

[Peter Kasting, 2016/04/06 22:35:39]

Why do we need this script?

It won't affect the build or output of Chromium at all.  The only thing it will
do is slightly reduce the source code footprint on disk.

Against that small upside, we have the maintenance downside that
(a) This could break future updates if they pout a necessary file in one of
these places
(b) It's not obvious how to create this list or if it's exhaustive, so it's not
clear how maintainers should modify it in the future, so over time it will have
an increasing number of coverage gaps

I think we should remove this script entirely and you should check the full
upstream release into the tree.

[xyzzyz, 2016/04/07 18:55:02]

Along with the patch 0002, it affects protoc slightly. I removed unnecessary
stuff, because most other libraries in third_party seem to also do it. Having
cleaner repository makes it easier to work with, and the Chromium build/code
review tools are a total pain to work with if your CLs are huge.

I don't think it's very hard to create this list. If it break future update, the
person doing the update will not have a hard time finding what went wrong.

[Peter Kasting, 2016/04/07 23:25:38]

In what way?  protoc won't support these inputs anymore?  That shouldn't be a
meaningful change from Chromium's perspective.
Definitely don't assume that any practice of anything in third_party/ is
desirable or should be a general pattern :).
I don't think this makes any meaningful difference.  This CL is already far
larger than the tools can deal with perfectly (e.g. "download patch" is
disabled).  The difference between "way too huge" and "slightly larger than way
too huge" is negligible.

I really can't see any meaningful benefit of this.  It's of far more value to
have a repo copy that exactly matches upstream than one that has a bunch of
diffs due to missing files.  That makes it easier to tell what's different when
you download a new copy into the old location.  I considered and rejected this
idea of pruning these bits of the repository during my previous update attempt
in part for this reason.
Having been the person who tried to do the previous update, I would not have
wanted to parse this list and figure out how to map it onto the current repo
state.

I continue to think you should undo this step and remove this script.  There's a
reason I didn't add it last time, and past maintainers before me didn't have
this.

[Peter Kasting, 2016/04/13 02:11:44]

All of my above concerns still stand.  I still believe you should not have this
script, the sources in question should be part of this patch, and they should be
listed appropriately (where applicable) in the relevant build files.

[xyzzyz, 2016/04/14 00:23:56]

Pulled full protobuf release and deleted this script.

+
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+
+cd $DIR
+
+rm -f appveyor.*
+rm -f autogen.sh
+rm -rf benchmarks/
+rm -f BUILD
+rm -rf cmake/
+rm -f configure.ac
+rm -rf conformance/
+rm -rf csharp/
+rm -rf editors/
+rm -rf examples/
+rm -f generate_descriptor_proto.sh
+rm -f .gitignore
+rm -f gmock.BUILD
+rm -f INSTALL.txt
+rm -rf java/
+rm -rf javanano/
+rm -rf js/
+rm -rf m4/
+rm -rf Makefile.am
+rm -rf more_tests/
+rm -rf objectivec/
+rm -f post_process_dist.sh
+rm -f protobuf.bzl
+rm -f protobuf-lite.pc.in
+rm -f protobuf.pc.in
+rm -f Protobuf.podspec
+rm -rf protoc-artifacts/
+rm -rf ruby/
+rm -f six.BUILD
+rm -f travis.sh
+rm -f .travis.yml
+rm -f update_file_lists.sh
+rm -rf util/
+rm -f WORKSPACE
+
+# src/
+rm -rf src/solaris/
+rm -f src/Makefile.am
+
+# src/google/protobuf/compiler/
+rm -rf src/google/protobuf/compiler/csharp
+rm -rf src/google/protobuf/compiler/java
+rm -rf src/google/protobuf/compiler/javanano
+rm -rf src/google/protobuf/compiler/js
+rm -rf src/google/protobuf/compiler/objectivec
+rm -rf src/google/protobuf/compiler/ruby