third_party/protobuf/OWNERS - Issue 1842653006: Update //third_party/protobuf to version 3.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/protobuf/OWNERS

Issue 1842653006: Update //third_party/protobuf to version 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update sync unittest and README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 agl@chromium.org

2 scottmg@chromium.org
Peter Kasting 2016/04/06 22:35:39 You shouldn't be deleting this file. We need OWNE You shouldn't be deleting this file. We need OWNERS. You should probably change the contents of this to list yourself as OWNER instead. xyzzyz 2016/04/07 18:55:02 Ah, the deletion is an accident. If I list mysel Show quoted text On 2016/04/06 22:35:39, Peter Kasting wrote: > You shouldn't be deleting this file. We need OWNERS. > > You should probably change the contents of this to list yourself as OWNER > instead. Ah, the deletion is an accident. If I list myself as an owner, I still need a second owner too. Who would be a good candidate? Peter Kasting 2016/04/07 23:25:38 List me, as I've done the most work with this dir Show quoted text On 2016/04/07 18:55:02, xyzzyz wrote: > On 2016/04/06 22:35:39, Peter Kasting wrote: > > You shouldn't be deleting this file. We need OWNERS. > > > > You should probably change the contents of this to list yourself as OWNER > > instead. > > Ah, the deletion is an accident. > > If I list myself as an owner, I still need a second owner too. Who would be a > good candidate? List me, as I've done the most work with this dir in recent memory. xyzzyz 2016/04/11 19:34:40 Done. Show quoted text On 2016/04/07 23:25:38, Peter Kasting wrote: > On 2016/04/07 18:55:02, xyzzyz wrote: > > On 2016/04/06 22:35:39, Peter Kasting wrote: > > > You shouldn't be deleting this file. We need OWNERS. > > > > > > You should probably change the contents of this to list yourself as OWNER > > > instead. > > > > Ah, the deletion is an accident. > > > > If I list myself as an owner, I still need a second owner too. Who would be a > > good candidate? > > List me, as I've done the most work with this dir in recent memory. Done.
OLD	NEW

« third_party/protobuf/BUILD.gn ('K') | « third_party/protobuf/LICENSE ('k') | third_party/protobuf/README.chromium » ('j') | third_party/protobuf/README.chromium » ('J')