Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1842653004: [Layout API] Add viewRect() to LayoutViewItem and use it in FrameView (Closed)

Created:
4 years, 8 months ago by pilgrim_google
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Add viewRect() to LayoutViewItem and use it in FrameView This adds 1 method, viewRect(), to LayoutViewItem in the new layout API and calls it from FrameView::collectFrameTimingRequests. There are a few other references to other methods in the same function which will require more extensive refactoring, which are not included in this CL. There are no functional changes. BUG=499321 Committed: https://crrev.com/410c8dcead74bb6adab891816062a95ef22b6c68 Cr-Commit-Position: refs/heads/master@{#383827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutViewItem.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
4 years, 8 months ago (2016-03-29 20:15:18 UTC) #2
eae
LGTM
4 years, 8 months ago (2016-03-29 20:35:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842653004/1
4 years, 8 months ago (2016-03-29 20:36:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 21:20:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:22:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/410c8dcead74bb6adab891816062a95ef22b6c68
Cr-Commit-Position: refs/heads/master@{#383827}

Powered by Google App Engine
This is Rietveld 408576698