Add --disable-webusb-security flag for testing existing devices.

chrome/browser/usb/usb_chooser_bubble_controller.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/usb/usb_chooser_bubble_controller.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
+#include "base/command_line.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/usb/usb_chooser_context.h"
 #include "chrome/browser/usb/usb_chooser_context_factory.h"
 #include "chrome/browser/usb/web_usb_histograms.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 #include "components/bubble/bubble_controller.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "device/core/device_client.h"
 #include "device/usb/mojo/type_converters.h"
 #include "device/usb/usb_device.h"
 #include "device/usb/usb_device_filter.h"
 #include "device/usb/webusb_descriptors.h"
 #include "url/gurl.h"
 
+namespace {
+
+bool FindInWebUsbAllowedOrigins(
+    const device::WebUsbAllowedOrigins* allowed_origins,
+    const GURL& origin) {
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kDisableWebUsbSecurity))
+    return true;
+  return device::FindInWebUsbAllowedOrigins(allowed_origins, origin);

[Peter Kasting, 2016/03/29 23:29:31]

Nit: Shorter:

  return base::CommandLine::ForCurrentProcess()->HasSwitch(
             switches::kDisableWebUsbSecurity) ||
         device::FindInWebUsbAllowedOrigins(allowed_origins, origin);

[Reilly Grant (use Gerrit), 2016/03/30 20:26:43]

Done.

+}
+
+}  // namespace
+
 UsbChooserBubbleController::UsbChooserBubbleController(
     content::RenderFrameHost* owner,
     mojo::Array<device::usb::DeviceFilterPtr> device_filters,
     content::RenderFrameHost* render_frame_host,
     const device::usb::ChooserService::GetPermissionCallback& callback)
     : ChooserBubbleController(owner),
       render_frame_host_(render_frame_host),
       callback_(callback),
       usb_service_observer_(this),
       weak_factory_(this) {
@@ skipping 63 matching lines @@
 
   if (bubble_reference_)
     bubble_reference_->CloseBubble(BUBBLE_CLOSE_CANCELED);
 }
 
 void UsbChooserBubbleController::Close() {}
 
 void UsbChooserBubbleController::OnDeviceAdded(
     scoped_refptr<device::UsbDevice> device) {
   if (device::UsbDeviceFilter::MatchesAny(device, filters_) &&
-      FindInWebUsbAllowedOrigins(
+      ::FindInWebUsbAllowedOrigins(

[Peter Kasting, 2016/03/29 23:29:31]

Don't make changes where we add identically-named functions such that the
presence or absence of :: matters.

Instead, either put the changes you've made above into the function these were
previously referencing, or use a different function name.  (2 places)

[Reilly Grant (use Gerrit), 2016/03/30 20:26:43]

Layering-wise I can't move the check into device::FindInWebUsbAllowedOrigins but
I've made a new function UsbChooserBubbleController::DisplayDevice() that
contains the whole boolean expression from this if statement (including the new
logic) and puts it in a single place so that at least it isn't duplicated here
and in GotUsbDeviceList.

           device->webusb_allowed_origins(),
           render_frame_host_->GetLastCommittedURL().GetOrigin())) {
     devices_.push_back(std::make_pair(device, device->product_string()));
     if (observer())
       observer()->OnOptionAdded(devices_.size() - 1);
   }
 }
 
 GURL UsbChooserBubbleController::GetHelpCenterUrl() const {
   return GURL(chrome::kChooserUsbOverviewURL);
@@ skipping 16 matching lines @@
     BubbleReference bubble_reference) {
   bubble_reference_ = bubble_reference;
 }
 
 // Get a list of devices that can be shown in the chooser bubble UI for
 // user to grant permsssion.
 void UsbChooserBubbleController::GotUsbDeviceList(
     const std::vector<scoped_refptr<device::UsbDevice>>& devices) {
   for (const auto& device : devices) {
     if (device::UsbDeviceFilter::MatchesAny(device, filters_) &&
-        FindInWebUsbAllowedOrigins(
+        ::FindInWebUsbAllowedOrigins(
             device->webusb_allowed_origins(),
             render_frame_host_->GetLastCommittedURL().GetOrigin())) {
       devices_.push_back(std::make_pair(device, device->product_string()));
     }
   }
   if (observer())
     observer()->OnOptionsInitialized();
 }