Issue 1842643003: Iframe with srcDoc should resolve FragmentURIs internally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1842643003: Iframe with srcDoc should resolve FragmentURIs internally (Closed)

Created:
4 years, 8 months ago by Shanmuga Pandi

Modified:
4 years, 4 months ago

Reviewers:
fs

CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Iframe with srcDoc should resolve FragmentURIs internally BUG=598035

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -2 lines)			Patch
A	third_party/WebKit/LayoutTests/svg/as-iframe/svg-in-iframe-srcdoc-with-fragment.html	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/svg/as-iframe/svg-in-iframe-srcdoc-with-fragment-expected.html	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/svg/SVGURIReference.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

4 years, 8 months ago (2016-03-29 13:11:27 UTC) #3

I don't think we should be hacking around this for specific schemes like this
without a better reason. As I said in the bug, similar cases are currently being
discussed in the CSS WG [1].

Also, this fix only changes the isExternalURIReference predicate, which means
URL resolution in this case will be inconsistent.

[1] https://lists.w3.org/Archives/Public/www-style/2016Mar/0298.html

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages