Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1842613002: VM/Mac: Prevent dead_strip from removing API functions. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM/Mac: Prevent dead_strip from removing API functions. strip -x xcodebuild/ReleaseX64/dart 6915912 -> 6996096 (+1.15%) BUG=http://dartbug.com/26113 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/92d492f9e27fb2c2491dae7514fb2d517558df3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/include/dart_api.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
4 years, 8 months ago (2016-03-29 17:46:00 UTC) #4
Ivan Posva
LGTM -ip
4 years, 8 months ago (2016-03-29 19:32:11 UTC) #5
rmacnak
4 years, 8 months ago (2016-03-29 20:08:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92d492f9e27fb2c2491dae7514fb2d517558df3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698