Revert of Patch to try dump-on-DCHECK.

Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of https://codereview.chromium.org/1814423002/ )

Reason for revert:
This might be breaking official build.

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231
Committed: https://crrev.com/1a74ae201b277300bc0fd81d8415143a07a18b20
Cr-Commit-Position: refs/heads/master@{#383906}

[shinyak, 2016-03-30 04:15:40]

Created Revert of Patch to try dump-on-DCHECK.

[commit-bot: I haz the power, 2016-03-30 04:16:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842563008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842563008/1

[commit-bot: I haz the power, 2016-03-30 04:17:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-30 04:17:33]

Failed to apply patch for build/common.gypi:
While running git apply --index -3 -p1;
  error: patch failed: build/common.gypi:722
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: build/common.gypi: patch does not apply

Patch:       build/common.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
a26a25c0f03c3e56a32f01452858e4e37c8800d0..aea53b922e0f8e0491aa2dda13899dac58b39e66
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -722,15 +722,6 @@
       'optimize_jni_generation%': 1,
 
       'conditions': [
-        # In Windows official builds, enable DCHECK as dump-without-crashing.
-        ['OS=="win" and buildtype=="Official"', {
-          'dcheck_always_on%': 1,
-          'dcheck_is_dump_without_crash': 1,
-        }, {
-          'dcheck_always_on%': 0,
-          'dcheck_is_dump_without_crash': 0,
-        }],
-
         # A flag for POSIX platforms
         ['OS=="win"', {
           'os_posix%': 0,
@@ -1202,7 +1193,6 @@
     'fastbuild%': '<(fastbuild)',
     'win_z7%': '<(win_z7)',
     'dcheck_always_on%': '<(dcheck_always_on)',
-    'dcheck_is_dump_without_crash%': '<(dcheck_is_dump_without_crash)',
     'tracing_like_official_build%': '<(tracing_like_official_build)',
     'fieldtrial_testing_like_official_build%':
'<(fieldtrial_testing_like_official_build)',
     'arm_version%': '<(arm_version)',
@@ -2868,9 +2858,6 @@
       ['dcheck_always_on!=0', {
         'defines': ['DCHECK_ALWAYS_ON=1'],
       }],  # dcheck_always_on!=0
-      ['dcheck_is_dump_without_crash!=0', {
-        'defines': ['DCHECK_IS_DUMP_WITHOUT_CRASH=1'],
-      }],  # dcheck_is_dump_without_crash!=0
       ['tracing_like_official_build!=0', {
         'defines': ['TRACING_IS_OFFICIAL_BUILD=1'],
       }],  # tracing_like_official_build!=0

[commit-bot: I haz the power, 2016-03-30 04:18:30]

Description was changed from

==========
Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
This might be breaking official build. 

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231
==========

to

==========
Revert of Patch to try dump-on-DCHECK. (patchset #11 id:200001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
This might be breaking official build.

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}

TBR=danakj@chromium.org,scottmg@chromium.org,wez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596231

Committed: https://crrev.com/1a74ae201b277300bc0fd81d8415143a07a18b20
Cr-Commit-Position: refs/heads/master@{#383906}
==========

[commit-bot: I haz the power, 2016-03-30 04:18:31]

Patchset 1 (id:??) landed as
https://crrev.com/1a74ae201b277300bc0fd81d8415143a07a18b20
Cr-Commit-Position: refs/heads/master@{#383906}