Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Side by Side Diff: test/mjsunit/array-sort.js

Issue 1842563004: [runtime] Don't call GetArrayKeys on proxies. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/js/array.js ('K') | « src/js/array.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 assertEquals(0, Number(Array.prototype.sort.call(x))); 459 assertEquals(0, Number(Array.prototype.sort.call(x)));
460 assertEquals(4, x[0]); 460 assertEquals(4, x[0]);
461 assertEquals(5, x[1]); 461 assertEquals(5, x[1]);
462 assertArrayEquals(["0", "1"], Object.getOwnPropertyNames(x)); 462 assertArrayEquals(["0", "1"], Object.getOwnPropertyNames(x));
463 // The following would throw if ToObject weren't called. 463 // The following would throw if ToObject weren't called.
464 assertEquals(0, Number(Array.prototype.sort.call(0))); 464 assertEquals(0, Number(Array.prototype.sort.call(0)));
465 } 465 }
466 TestSortToObject(); 466 TestSortToObject();
467 467
468 function TestSortOnProxy() { 468 function TestSortOnProxy() {
469 var p = new Proxy([2,1,3], {}); 469 {
470 assertEquals([1,2,3], p.sort()); 470 var p = new Proxy([2,1,3], {});
471 assertEquals([1,2,3], p.sort());
472 }
473
474 {
475 function f() { return arguments };
476 var a = f(2,1,3);
477 a.__proto__ = new Proxy({}, {});
478 assertEquals([1,2,3], [...(Array.prototype.sort.apply(a))]);
479 }
471 } 480 }
472 TestSortOnProxy(); 481 TestSortOnProxy();
OLDNEW
« src/js/array.js ('K') | « src/js/array.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698