Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1842563004: [runtime] Don't call GetArrayKeys on proxies. (Closed)

Created:
4 years, 8 months ago by neis
Modified:
4 years, 8 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Don't call GetArrayKeys on proxies. This fixes another bug in Array.prototype.sort (when the array is not a JSArray and there is a proxy on the prototype chain). R=cbruni@chromium.org BUG=chromium:596866 LOG=n Committed: https://crrev.com/7ed2d00bc353c7401e4662cded2bc4de09670cb5 Cr-Commit-Position: refs/heads/master@{#35101}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/js/array.js View 2 chunks +2 lines, -2 lines 1 comment Download
M test/mjsunit/array-sort.js View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 8 months ago (2016-03-29 09:48:45 UTC) #1
Camillo Bruni
lgtm https://codereview.chromium.org/1842563004/diff/1/src/js/array.js File src/js/array.js (right): https://codereview.chromium.org/1842563004/diff/1/src/js/array.js#newcode1052 src/js/array.js:1052: var indices = IS_PROXY(proto) ? length : %GetArrayKeys(proto, ...
4 years, 8 months ago (2016-03-29 11:34:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842563004/1
4 years, 8 months ago (2016-03-29 12:05:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 12:34:09 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 12:36:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ed2d00bc353c7401e4662cded2bc4de09670cb5
Cr-Commit-Position: refs/heads/master@{#35101}

Powered by Google App Engine
This is Rietveld 408576698