Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: pkg/analyzer/test/src/summary/summary_common.dart

Issue 1842533002: Don't serialize Label in NamedExpression as a label declaration. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_ast.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/summary_common.dart
diff --git a/pkg/analyzer/test/src/summary/summary_common.dart b/pkg/analyzer/test/src/summary/summary_common.dart
index e6685d895e7bca9b3c6f0ed942e48dc89015e139..ec24bd4dde83d1c30a03c1f227c299f64b5596a6 100644
--- a/pkg/analyzer/test/src/summary/summary_common.dart
+++ b/pkg/analyzer/test/src/summary/summary_common.dart
@@ -4673,12 +4673,14 @@ f() {
bbb: switch (42) {
ccc: case 0:
break;
+ ddd: default:
+ break;
}
}
''';
UnlinkedExecutable executable = serializeExecutableText(code);
List<UnlinkedLabel> labels = executable.localLabels;
- expect(labels, hasLength(3));
+ expect(labels, hasLength(4));
{
UnlinkedLabel aaa = labels.singleWhere((l) => l.name == 'aaa');
expect(aaa, isNotNull);
@@ -4697,6 +4699,12 @@ f() {
expect(ccc.isOnSwitchMember, isTrue);
expect(ccc.isOnSwitchStatement, isFalse);
}
+ {
+ UnlinkedLabel ccc = labels.singleWhere((l) => l.name == 'ddd');
+ expect(ccc, isNotNull);
+ expect(ccc.isOnSwitchMember, isTrue);
+ expect(ccc.isOnSwitchStatement, isFalse);
+ }
}
test_executable_localLabels_inTopLevelGetter() {
@@ -4724,6 +4732,18 @@ get g {
}
}
+ test_executable_localLabels_namedExpressionLabel() {
+ String code = r'''
+f() {
+ foo(p: 42);
+}
+foo({int p}) {}
+''';
+ UnlinkedExecutable executable = serializeExecutableText(code);
+ List<UnlinkedLabel> labels = executable.localLabels;
+ expect(labels, isEmpty);
+ }
+
test_executable_localVariables_catch() {
String code = r'''
f() { // 1
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_ast.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698