Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1842533002: Don't serialize Label in NamedExpression as a label declaration. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't serialize Label in NamedExpression as a label declaration. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d8af43e5e2390a69a5cb76763e10efe4dd30acd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-03-28 21:15:10 UTC) #1
Paul Berry
lgtm
4 years, 8 months ago (2016-03-28 21:20:00 UTC) #2
scheglov
4 years, 8 months ago (2016-03-28 21:53:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8af43e5e2390a69a5cb76763e10efe4dd30acd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698