Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1842523003: Rename consumeImage to consumeImageOrNone in CSSPropertyParser (Closed)

Created:
4 years, 8 months ago by nainar
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@consumeContent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename consumeImage to consumeImageOrNone in CSSPropertyParser This patch renames consumeImage to consumeImageOrNone to more accurately represent what the function does. It consumes an ident in the case CSSValueNone is specified and consumes an image otherwise. Committed: https://crrev.com/e1601140c77d33943d613e2242d48d9886f6ceb3 Cr-Commit-Position: refs/heads/master@{#383881}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 8 chunks +15 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
nainar
PTAL? Thanks!
4 years, 8 months ago (2016-03-29 08:05:51 UTC) #2
Timothy Loh
lgtm https://codereview.chromium.org/1842523003/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1842523003/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode2621 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2621: if (range.peek().id() == CSSValueNone) if you want you ...
4 years, 8 months ago (2016-03-29 08:58:33 UTC) #3
nainar
https://codereview.chromium.org/1842523003/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1842523003/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode2621 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2621: if (range.peek().id() == CSSValueNone) Removing as part of this ...
4 years, 8 months ago (2016-03-29 22:39:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842523003/20001
4 years, 8 months ago (2016-03-29 22:40:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 00:56:53 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 00:58:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1601140c77d33943d613e2242d48d9886f6ceb3
Cr-Commit-Position: refs/heads/master@{#383881}

Powered by Google App Engine
This is Rietveld 408576698