Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1842523002: Fix the H.264 config detection code which lead to video playback errors. (Closed)

Created:
4 years, 8 months ago by ananta
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the H.264 config detection code which lead to video playback errors. The H264Parser class needs to be a member of the H264ConfigChangeDetector class. Currently we use a new instance of the H264Parser class to detect stream configurations which causes errors because we fail to map a PPS to its SPS etc. Maintaining the same instance of the parser alleviates this problem. BUG=597725 Committed: https://crrev.com/1cfde376b8a9c38cbbc6c0b63aa25edf2cfe1cb1 Cr-Commit-Position: refs/heads/master@{#383577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.h View 3 chunks +4 lines, -1 line 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator_win.cc View 7 chunks +13 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
iyengar
4 years, 8 months ago (2016-03-28 20:53:23 UTC) #2
iyengar
4 years, 8 months ago (2016-03-28 20:53:39 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 8 months ago (2016-03-28 21:52:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842523002/1
4 years, 8 months ago (2016-03-28 21:57:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 22:08:27 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 22:09:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cfde376b8a9c38cbbc6c0b63aa25edf2cfe1cb1
Cr-Commit-Position: refs/heads/master@{#383577}

Powered by Google App Engine
This is Rietveld 408576698