MSE: Cleanup WebM tracks parser initialization

MSE: Cleanup WebM tracks parser initialization

Introduces re-usable parser reinitialization, enabling
code to set initial values in one place.

Committed: https://crrev.com/b35d9a381202652f32d2817672ac85604b07baf9
Cr-Commit-Position: refs/heads/master@{#383586}

[wolenetz, 2016-03-28 20:40:29]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 20:40:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842503002/1

[wolenetz, 2016-03-28 20:42:06]

wolenetz@chromium.org changed reviewers:
+ chcunningham@chromium.org

[wolenetz, 2016-03-28 20:42:06]

A bit of cleanup as requested in
https://codereview.chromium.org/1826583003/diff/1/media/formats/webm/webm_tra...

[wolenetz, 2016-03-28 20:45:07]

https://codereview.chromium.org/1842503002/diff/1/media/formats/webm/webm_tra...
File media/formats/webm/webm_tracks_parser.cc (right):

https://codereview.chromium.org/1842503002/diff/1/media/formats/webm/webm_tra...
media/formats/webm/webm_tracks_parser.cc:87: WebMListParser
parser(kWebMIdTracks, this);
Note, this works without invoking Reset() here too because all users of this
class assume it's a one-shot deal and construct it each time. I could add
Reset() to top of ::Parse() with extra runtime cost, to make it more robust
against future usage change by callers. wdyt?

[chcunningham, 2016-03-28 20:45:21]

lgtm

[wolenetz, 2016-03-28 20:53:45]

Thanks. PTAL again

https://codereview.chromium.org/1842503002/diff/1/media/formats/webm/webm_tra...
File media/formats/webm/webm_tracks_parser.cc (right):

https://codereview.chromium.org/1842503002/diff/1/media/formats/webm/webm_tra...
media/formats/webm/webm_tracks_parser.cc:87: WebMListParser
parser(kWebMIdTracks, this);
On 2016/03/28 20:45:07, wolenetz wrote:
> Note, this works without invoking Reset() here too because all users of this
> class assume it's a one-shot deal and construct it each time. I could add
> Reset() to top of ::Parse() with extra runtime cost, to make it more robust
> against future usage change by callers. wdyt?

From quick chat, I've added usage of a flag here to track whether or not a
Reset() is needed.

[chcunningham, 2016-03-28 21:06:43]

lgtm

[wolenetz, 2016-03-28 21:06:54]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2016-03-28 21:07:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842503002/20001

[commit-bot: I haz the power, 2016-03-28 22:40:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-28 22:41:15]

Description was changed from

==========
MSE: Cleanup WebM tracks parser initialization

Introduces re-usable parser reinitialization, enabling
code to set initial values in one place.
==========

to

==========
MSE: Cleanup WebM tracks parser initialization

Introduces re-usable parser reinitialization, enabling
code to set initial values in one place.

Committed: https://crrev.com/b35d9a381202652f32d2817672ac85604b07baf9
Cr-Commit-Position: refs/heads/master@{#383586}
==========

[commit-bot: I haz the power, 2016-03-28 22:41:15]

Patchset 2 (id:??) landed as
https://crrev.com/b35d9a381202652f32d2817672ac85604b07baf9
Cr-Commit-Position: refs/heads/master@{#383586}