Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1842493002: Enable IsolatedAppTest.CookieIsolation on windows. (Closed)

Created:
4 years, 8 months ago by lazyboy
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable IsolatedAppTest.CookieIsolation on windows. It was disabled because it used to flake on windows XP. Re-enabling since we don't run XP bots anymore. BUG=86562 Test=Tried the test 100 times (see patch set #1) on try bot and noticed no single failure or flake in the following two bots: 1) win_chromium_rel_ng: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/195077/steps/browser_tests%20%28with%20patch%29%20on%20Windows-7-SP1/logs/stdio 2) win_chromium_x64_rel_ng: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/188186/steps/browser_tests%20%28with%20patch%29%20on%20Windows-7-SP1/logs/stdio Committed: https://crrev.com/44ba4c41cd5f558bc2fa568dd3df34ec668cf4fb Cr-Commit-Position: refs/heads/master@{#383593}

Patch Set 1 #

Patch Set 2 : remove test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/extensions/isolated_app_browsertest.cc View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
lazyboy
4 years, 8 months ago (2016-03-28 21:59:11 UTC) #5
asargent_no_longer_on_chrome
good luck little test, we're all rooting for you! lgtm
4 years, 8 months ago (2016-03-28 22:01:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842493002/20001
4 years, 8 months ago (2016-03-28 22:35:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-28 23:04:49 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:07:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44ba4c41cd5f558bc2fa568dd3df34ec668cf4fb
Cr-Commit-Position: refs/heads/master@{#383593}

Powered by Google App Engine
This is Rietveld 408576698