Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 1842433002: When summarize AST, include local variables in loops and try-catch. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When summarize AST, include local variables in loops and try-catch. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3899031ff500a0a8e3577e371b28d25bc1a14c3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -8 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 8 chunks +72 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-03-28 18:33:10 UTC) #1
Paul Berry
lgtm
4 years, 8 months ago (2016-03-28 18:57:35 UTC) #2
scheglov
4 years, 8 months ago (2016-03-28 19:00:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3899031ff500a0a8e3577e371b28d25bc1a14c3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698