Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html

Issue 1842403004: MD Settings: Certificate manager, move "Import" button to the tab level. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html
diff --git a/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html b/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html
index 506d1c6568510e2f1a6ca34246e0a5733db477dc..5e3d0eea3650fb07c451733390f7f9ea0c43aac4 100644
--- a/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html
+++ b/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html
@@ -13,9 +13,17 @@
<dom-module id="settings-certificate-manager-page">
<template>
<style>
- /* TODO(dpapad): Find exact color value to use. */
:host {
- --paper-tabs-selection-bar-color: blue;
+ --paper-tabs-selection-bar-color: var(--paper-blue-500);
+ }
+
+ paper-tabs {
+ height: 40px;
+ margin-bottom: 24px;
+ }
+
+ paper-tab {
+ text-transform: uppercase;
Dan Beam 2016/04/01 18:38:02 hmmm, why are we differing from Polymer in this re
dpapad 2016/04/01 21:13:17 We don't use paper-tabs anywhere else in settings,
Dan Beam 2016/04/02 02:08:16 it's because all the demos are IN ALL UPPER (but n
}
</style>
@@ -43,7 +51,7 @@
</settings-certificates-error-dialog>
</template>
- <paper-tabs selected="{{selected}}">
+ <paper-tabs noink selected="{{selected}}">
Dan Beam 2016/04/01 18:38:02 why no ink?
dpapad 2016/04/01 21:13:17 The mocks don't specify ink/noink on this one. I c
Dan Beam 2016/04/02 02:08:16 because this is unspecified i don't care, but i'd
<paper-tab>$i18n{certificateManagerYourCertificates}</paper-tab>
<paper-tab>$i18n{certificateManagerServers}</paper-tab>
<paper-tab>$i18n{certificateManagerAuthorities}</paper-tab>

Powered by Google App Engine
This is Rietveld 408576698