Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Unified Diff: blimp/client/app/android/java/res/xml/about_blimp_preferences.xml

Issue 1842403003: Added Version Info page to toolbar menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@toolbar_menu
Patch Set: Addressed review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/app/android/java/res/xml/about_blimp_preferences.xml
diff --git a/chrome/android/java/res/xml/about_chrome_preferences.xml b/blimp/client/app/android/java/res/xml/about_blimp_preferences.xml
similarity index 51%
copy from chrome/android/java/res/xml/about_chrome_preferences.xml
copy to blimp/client/app/android/java/res/xml/about_blimp_preferences.xml
index 5b8de44f99edb79780c117fccd6ee64dff0d3d43..d3a00963283ec355f452d59f549c374f01f9a4e2 100644
--- a/chrome/android/java/res/xml/about_chrome_preferences.xml
+++ b/blimp/client/app/android/java/res/xml/about_blimp_preferences.xml
@@ -1,9 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright 2014 The Chromium Authors. All rights reserved.
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
+<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
+ android:title="@string/about_blimp_preferences">
<Preference
android:key="application_version"
android:title="@string/application_version_title" />
@@ -11,7 +12,12 @@
android:key="os_version"
android:title="@string/os_version_title" />
<Preference
- android:fragment="org.chromium.chrome.browser.preferences.LegalInformationPreferences"
- android:key="legal_information"
- android:title="@string/legal_information_title" />
+ android:key="blimp_engine_ip"
+ android:title="@string/blimp_engine_ip" />
+ <Preference
+ android:key="blimp_engine_version"
+ android:title="@string/blimp_engine_version" />
+ <Preference
+ android:key="blimp_assigner_url"
+ android:title="@string/blimp_assigner_url" />
</PreferenceScreen>

Powered by Google App Engine
This is Rietveld 408576698