blimp/client/app/android/blimp_client_session_android.h - Issue 1842403003: Added Version Info page to toolbar menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/blimp_client_session_android.h

Issue 1842403003: Added Version Info page to toolbar menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@toolbar_menu

Patch Set: Addressed review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/app/android/blimp_client_session_android.h

diff --git a/blimp/client/app/android/blimp_client_session_android.h b/blimp/client/app/android/blimp_client_session_android.h

index e0d0deff410c4e11c86ea6c554717078aeaff34a..345a926810a2cf7355c9c7d81a8e0e010fab4c17 100644

--- a/blimp/client/app/android/blimp_client_session_android.h

+++ b/blimp/client/app/android/blimp_client_session_android.h

@@ -37,8 +37,8 @@ class BlimpClientSessionAndroid : public BlimpClientSession {

~BlimpClientSessionAndroid() override;

// BlimpClientSession implementation.

- void OnAssignmentConnectionAttempted(

- AssignmentSource::Result result) override;

+ void OnAssignmentConnectionAttempted(AssignmentSource::Result result,

+ const Assignment& assignment) override;

// NetworkEventObserver implementation.

void OnConnected() override;